usb: phy: remove the i2c retry
Since suspend/resume time is limited about 150 ms, if eusb driver keep
doing retries during system suspend/resume, the total time will be
longer than the criteria.
This patch will remove the retry to fix this problem.
Bug: 316538540
Change-Id: Ifd36209676e057236b480abc2f0abb2653279dc8
Signed-off-by: Ray Chi <raychi@google.com>
diff --git a/drivers/phy/samsung/eusb_repeater.c b/drivers/phy/samsung/eusb_repeater.c
index c6ad00a..5016670 100644
--- a/drivers/phy/samsung/eusb_repeater.c
+++ b/drivers/phy/samsung/eusb_repeater.c
@@ -186,32 +186,21 @@
static int eusb_repeater_ctrl(int value)
{
struct eusb_repeater_data *tud = g_tud;
- int i, ret = 0;
+ int ret = 0;
u8 read_data, write_data;
- for (i = 0; i < TUSB_MODE_CONTROL_RETRY_CNT; i++) {
- ret = eusb_repeater_read_reg(tud, I2C_GLOBAL_CONFIG, &read_data, 1);
- if (ret < 0)
- goto retry;
+ ret = eusb_repeater_read_reg(tud, I2C_GLOBAL_CONFIG, &read_data, 1);
+ if (ret < 0)
+ goto err;
- write_data = value ? (read_data & ~REG_DISABLE_P1) : (read_data | REG_DISABLE_P1);
- ret = eusb_repeater_write_reg(tud, I2C_GLOBAL_CONFIG, &write_data, 1);
- if (ret < 0)
- goto retry;
+ write_data = value ? (read_data & ~REG_DISABLE_P1) : (read_data | REG_DISABLE_P1);
+ ret = eusb_repeater_write_reg(tud, I2C_GLOBAL_CONFIG, &write_data, 1);
+ if (ret < 0)
+ goto err;
- ret = eusb_repeater_read_reg(tud, I2C_GLOBAL_CONFIG, &read_data, 1);
- if (ret < 0)
- goto retry;
-
- break;
-
-retry:
- if (i > 1)
- goto err;
-
- usleep_range(30 * 1000, 80 * 1000);
- }
-
+ ret = eusb_repeater_read_reg(tud, I2C_GLOBAL_CONFIG, &read_data, 1);
+ if (ret < 0)
+ goto err;
dev_info(tud->dev, "%s Disabled mode, reg = %x\n", value ? "Exit" : "Enter", read_data);
